Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update actions using old Node version #1111

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

doctorperceptron
Copy link
Contributor

@doctorperceptron doctorperceptron commented May 16, 2024

Many of our old actions use Node 16, which is deprecated in GitHub Actions. Bumping:

  • actions/checkout to v4
  • actions/setup-python to v5
  • actions/changed-files to v44
  • actions/cache to v3.2.2 (latest)

I have not bumped actions/upload-artifact or actions/download-artifact as v4 has breaking API changes and I will definitely mess that up.

Copy link
Collaborator

@ashishks0522 ashishks0522 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Collaborator

@rashidnhm rashidnhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the initiative on this!

If the goal is to remove all the warnings, we should also:

  • Bump actions/setup-python to using v5
  • Bump tj-actions/changed-files to v44

We should also build the demos as part of this PR just to be safe

@doctorperceptron doctorperceptron added the ci:build-all-qml-demos Build all the Demos for this Pull Request label May 22, 2024
@doctorperceptron doctorperceptron changed the title Update checkout action to v4 Update actions using old Node version May 22, 2024
Copy link

github-actions bot commented May 22, 2024

Thank you for opening this pull request.

You can find the built site at this link.

Deployment Info:

  • Pull Request ID: 1111
  • Deployment SHA: 77990be9bf4f9dc23c2639d89907040e3ad2a59e
    (The Deployment SHA refers to the latest commit hash the docs were built from)

Note: It may take several minutes for updates to this pull request to be reflected on the deployed site.

@doctorperceptron
Copy link
Contributor Author

@rashidnhm this is ready for another look. See the note above about the upload/download artifact actions. May need you to tackle those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:build-all-qml-demos Build all the Demos for this Pull Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants